Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add circular tests #27135

Conversation

scanlonp
Copy link
Contributor

@scanlonp scanlonp commented Sep 14, 2023

In DynamoDB, the Type AttributeValue can be a list, with the type ListAttributeValue, which is a list of AttributeValues. These tests use this circular reference.

AttributeValue docs
DynamoDB -> GetItem sdk docs and general docs


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 14, 2023 00:30
@github-actions github-actions bot added the p2 label Sep 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 14, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these tests passing?? 😱

],
},
},
TableName: new Uint8Array([97, 98, 99]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this shouldn't be encoded

],
},
{
M: { Name: { S: new Uint8Array([97, 98, 100]) }, Age: { N: 35 } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nor should these.

@mergify mergify bot deleted the branch aws:otaviom/number-parameters September 14, 2023 13:17
@mergify mergify bot closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants