Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 2.96.1 #27145

Merged
merged 4 commits into from
Sep 14, 2023
Merged

chore(release): 2.96.1 #27145

merged 4 commits into from
Sep 14, 2023

Conversation

sumupitchayan
Copy link
Contributor

See CHANGELOG

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

sumupitchayan and others added 3 commits September 14, 2023 11:31
@sumupitchayan
revert: "chore(ecs): clarify it's possible to use image digest on fro…
049153e 
…mEcrRepository" (#27143)

Reverts #27115

Renaming `tag` prop to `tagOrDigest` of the `ContainerImage.fromEcrRepository` function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.
@sumupitchayan
chore(release): 2.96.1
088e608
@sumupitchayan
Verify the heading of the patch entry is H2 (##) and not H3 (###)
3058369 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan added the pr/no-squash This PR should be merged instead of squash-merging it label Sep 14, 2023
@github-actions github-actions bot added the p2 label Sep 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 14, 2023 15:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 14, 2023
colifran
colifran reviewed Sep 14, 2023
View reviewed changes
CHANGELOG.v2.alpha.md Outdated Show resolved Hide resolved
@sumupitchayan
fix ## in alpha v2 changelog
0bc7c64 
Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0bc7c64
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d2edb00 into v2-release Sep 14, 2023
9 checks passed
@mergify mergify bot deleted the patch/v2.96.1 branch September 14, 2023 16:15
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumupitchayan @aws-cdk-automation @colifran