-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): support of m7i and m7i-flex ec2-instancetypes #27156
feat(ec2): support of m7i and m7i-flex ec2-instancetypes #27156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request This PR is similar to this, which didnt need changes to readme and tests. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rearrange the order of the enum to be consistent with its current order. Put the instance types that are written in words right above their corresponding abbreviation.
Otherwise looks good. Thanks for this addition!
Pull request has been modified.
Thanks for the exemption. |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Support of M7i and M7i-flex EC2-Instancetypes.
They were introduced here and are also integrated in AWS-Cloudformation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license