-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sample-app): exclude all __pycache__ in cdk.json #27191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Following the cdk workshop for python I noticed that `cdk watch` watches files from `__pycache__`. This is an attempt to fix that. Steps to reproduce: 1. `cdk init sample-app --language python` 2. `cdk bootstrap` 3. Run `cdk watch` and notice that `__pycache__` folders are being watched: ``` 'watch' is observing directory 'cdk_workshop/__pycache__' for changes 'watch' is observing the file 'cdk_workshop/cdk_workshop_stack.py' for changes 'watch' is observing the file 'cdk_workshop/__pycache__/__init__.cpython-311.pyc' for changes 'watch' is observing the file 'cdk_workshop/__pycache__/cdk_workshop_stack.cpython-311.pyc' for changes ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Following the cdk workshop for python I noticed that
cdk watch
watches files from__pycache__
.This is an attempt to fix that.
Steps to reproduce:
cdk init sample-app --language python
cdk bootstrap
cdk watch
and notice that__pycache__
folders are being watched:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license