-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(batch): make instanceType
optional on multinode jobs
#27223
fix(batch): make instanceType
optional on multinode jobs
#27223
Conversation
Weird that setting something to optional is considered a breaking change. |
On the question of making properties optional, this comes up way too often, so I made an explainer for it: |
thanks for writeup @rix0rrr, that's helpful |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Make
instanceType
optional. It used to be required. It will default to a batch optimal instance type.The breaking change is for
MultiNodeJobDefinition.instanceType
, which is now optional. This is not truly breaking because everyone has this property explicitly set now, and will continue to have it set after this change.Closes #27185.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license