Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(awslint): Cache L1 constructs in the CFN resource linter. #27290

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

mikewrighton
Copy link
Contributor

@mikewrighton mikewrighton commented Sep 26, 2023

Incremental change to improve the performance of awslint. CfnResourceReflection.findByName() was checking the doc tags of every class in the assembly on each call, taking 170s for aws-cdk-lib. This change caches the tagged classes, eliminating the list traversal and taking findByName down to ~2s for the same package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 26, 2023 01:38
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 26, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mikewrighton mikewrighton changed the title Cache L1 constructs in the CFN resource linter. build(awslint): Cache L1 constructs in the CFN resource linter. Sep 26, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 26, 2023 14:18

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mikewrighton mikewrighton marked this pull request as ready for review September 26, 2023 18:32
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 27, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a50fce8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 68895ff into main Sep 27, 2023
15 of 16 checks passed
@mergify mergify bot deleted the mikewrighton-lint-perf branch September 27, 2023 12:02
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants