Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): Escaping newline characters in Step Functions intrinsics caused schema validation failures #27323

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

clareliguori
Copy link
Member

Closes #27304.

I ran the updated integ test without the code change and it correctly failed to deploy with a SCHEMA_VALIDATION_FAILED error, then it successfully deployed after the code change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… intrinsics caused schema validation failures

Signed-off-by: Clare Liguori <liguori@amazon.com>
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2 labels Sep 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2023 19:08
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@clareliguori clareliguori changed the title fix(aws-stepfunctions): Escaping newline characters in Step Functions intrinsics caused schema validation failures fix(stepfunctions): Escaping newline characters in Step Functions intrinsics caused schema validation failures Sep 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 27, 2023 19:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 27, 2023
@hoegertn
Copy link
Contributor

Looks good to me. Thanks for the fix.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 29, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 56f7639
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4e96edd into aws:main Sep 29, 2023
11 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@clareliguori clareliguori deleted the fix-sfn-intrinsics-newlines branch September 29, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions: JsonPath.format incorrectly escapes newlines
4 participants