Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cdk-build): Include lint commands in build timing info. #27326

Merged
merged 3 commits into from
Sep 28, 2023
Merged

build(cdk-build): Include lint commands in build timing info. #27326

merged 3 commits into from
Sep 28, 2023

Conversation

mikewrighton
Copy link
Contributor

@mikewrighton mikewrighton commented Sep 27, 2023 •
edited
Loading

Includes individual lint commands (eslint, pkglint, markdownlint, awslint) in the build timing info emitted by cdk-build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2023 22:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 27, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mikewrighton mikewrighton changed the title Include lint commands in build timing info. build(cdk-build): Include lint commands in build timing info. Sep 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 27, 2023 22:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mikewrighton mikewrighton marked this pull request as ready for review September 28, 2023 13:24
@mikewrighton @mrgrain
Update tools/@aws-cdk/cdk-build-tools/bin/cdk-lint.ts
b652f3b 
Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b652f3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7df11f4 into main Sep 28, 2023
13 of 14 checks passed
@mergify mergify bot deleted the mikewrighton-lint-timing branch September 28, 2023 14:15
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikewrighton @aws-cdk-automation @mrgrain