Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): declare cdk import stable #27390

Merged
merged 2 commits into from
Oct 4, 2023
Merged

feat(cli): declare cdk import stable #27390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d1ee8a
feat(cli): consider `cdk import` stable
rix0rrr Oct 3, 2023
cd35ad1
Merge branch 'main' into huijbers/stabilize-cdk-import
mergify[bot] Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/aws-cdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ For this reason, only use it for development purposes.
**⚠ Note #2**: This command is considered experimental,
and might have breaking changes in the future.

**⚠ Note #3**: Expected defaults for certain parameters may be different with the hotswap parameter. For example, an ECS service's minimum healthy percentage will currently be set to 0. Please review the source accordingly if this occurs.
**⚠ Note #3**: Expected defaults for certain parameters may be different with the hotswap parameter. For example, an ECS service's minimum healthy percentage will currently be set to 0. Please review the source accordingly if this occurs.

### `cdk watch`

Expand Down Expand Up @@ -548,17 +548,17 @@ To import an existing resource to a CDK stack, follow the following steps:

#### Limitations

This feature is currently in preview. Be aware of the following limitations:
This feature currently has the following limitations:

- Importing resources in nested stacks is not possible.
- Uses the deploy role credentials (necessary to read the encrypted staging
bucket). Requires a new version (version 12) of the bootstrap stack, for the added
IAM permissions to the `deploy-role`.
- Importing resources into nested stacks is not possible.
- There is no check on whether the properties you specify are correct and complete
for the imported resource. Try starting a drift detection operation after importing.
- Resources that depend on other resources must all be imported together, or one-by-one
in the right order. The CLI will not help you import dependent resources in the right
order, the CloudFormation deployment will fail with unresolved references.
in the right order. If you do not, the CloudFormation deployment will fail
with unresolved references.
- Uses the deploy role credentials (necessary to read the encrypted staging
bucket). Requires version 12 of the bootstrap stack, for the added
IAM permissions to the `deploy-role`.

### `cdk destroy`

Expand Down Expand Up @@ -619,7 +619,7 @@ boundaries see the [Security And Safety Dev Guide](https://github.com/aws/aws-cd

Once a bootstrap template has been deployed with a set of parameters, you must
use the `--no-previous-parameters` CLI flag to change any of these parameters on
future deployments.
future deployments.

> **Note** Please note that when you use this flag, you must resupply
>*all* previously supplied parameters.
Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/lib/cdk-toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,6 @@ export class CdkToolkit {
}

public async import(options: ImportOptions) {
print(chalk.grey("The 'cdk import' feature is currently in preview."));
const stacks = await this.selectStacksForDeploy(options.selector, true, true);

if (stacks.stackCount > 1) {
Expand Down
Loading