Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs-patterns): respect taskDefinition prop in QueueProcessingFargateService. #27410

Closed
wants to merge 4 commits into from

Conversation

alhridoy
Copy link

@alhridoy alhridoy commented Oct 5, 2023

Title: Fix for Issue #27360: taskDefinition prop ignored on QueueProcessingFargateService

Comment:

This pull request addresses the bug reported in Issue #27360. The QueueProcessingFargateService was not correctly handling the taskDefinition prop. If a taskDefinition was provided, it was being ignored and a new one was being created regardless.

Changes:

  • Modified the constructor of QueueProcessingFargateService to correctly handle the taskDefinition prop. If a taskDefinition is provided in the props, it is now used. If not, a new FargateTaskDefinition is created.

This change fixes the bug and allows the QueueProcessingFargateService to correctly use a provided taskDefinition.

Please review the changes and provide feedback.

Fixes #27360

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 5, 2023 06:26
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@alhridoy alhridoy changed the title Refactor task definition creation in QueueProcessingFargateService fix(aws-ecs-patterns): respect taskDefinition prop in QueueProcessingFargateService. Oct 5, 2023
@alhridoy alhridoy changed the title fix(aws-ecs-patterns): respect taskDefinition prop in QueueProcessingFargateService. fix(ecs-patterns): respect taskDefinition prop in QueueProcessingFargateService. Oct 5, 2023
@alhridoy
Copy link
Author

alhridoy commented Oct 7, 2023

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 7, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Oct 10, 2023
@vinayak-kukreja
Copy link
Contributor

Hey, I see you have requested for an exemption. Could you tell me why integration tests are not required for this change?

@vinayak-kukreja
Copy link
Contributor

The build is also currently failing. We would not be able to prioritize reviewing this PR if the build if failing.

Let me know if you have any questions.

@vinayak-kukreja vinayak-kukreja removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 10, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f496b52
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vinayak-kukreja vinayak-kukreja removed their assignment Oct 18, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 3, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ecs-patterns: taskDefinition prop ignored on QueueProcessingFargateService
3 participants