Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init-templates): update init templates to use the current LTS version of Java #27422

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

TheRealAmazonKendra
Copy link
Contributor

This change allows users to use more up-to-date java functionality. Java 8 is now only supported in limited circumstances so we should not set that version here.

REPLACE THIS TEXT BLOCK

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes #.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This change allows users to use more up-to-date java functionality. Java 8 is now only supported in limited circumstances so we should not set that version here.
@github-actions github-actions bot added the p2 label Oct 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 5, 2023 22:54
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 5, 2023
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline October 5, 2023 22:55 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 5, 2023
@TheRealAmazonKendra TheRealAmazonKendra changed the title chore: remove the specification for java 8 in init template feat(init-templates): allow init templates to use installed version of java instead of defaulting to java 8 Oct 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 5, 2023
3.0.0 tries to default to java 7, which is not supported.
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline October 6, 2023 00:39 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline October 6, 2023 19:03 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline October 6, 2023 20:53 — with GitHub Actions Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Oct 9, 2023
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(init-templates): allow init templates to use installed version of java instead of defaulting to java 8 feat(init-templates): update init templates to use the current LTS version of Java Oct 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 44cc7e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6c34c9a into main Oct 9, 2023
14 of 15 checks passed
@mergify mergify bot deleted the TheRealAmazonKendra/java-init branch October 9, 2023 15:45
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants