Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): deprecate aws-synthetics-alpha #27471

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Oct 9, 2023

Depends on #27470.

Deprecates the alpha module for aws-synthetics-alpha so that the last version of aws-synthetics-alpha points to the stable aws-cdk-lib/aws-synthetics.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 9, 2023 20:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2023
@@ -117,5 +117,6 @@
"naming/package-matches-directory",
"assert/assert-dependency"
]
}
},
"deprecated": "This package has been stabilized in aws-cdk-lib is no longer being updated under the -alpha name. Users should migrate to aws-<module> in aws-cdk-lib."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to try this. if jsii / npm does the deprecation for us, great. if not, then i will follow up and do it manually

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5646655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7d92a9c into main Oct 10, 2023
14 checks passed
@mergify mergify bot deleted the conroy/depsynthetics branch October 10, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants