-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(glue-alpha): prefix validation logic is incorrect #27472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. We should clean up the documentation in the SparkUIProps
. Line 392 should be updated to reflect the new validation. Once that is done, feel free to merge.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Co-authored-by: Parker Scanlon <69879391+scanlonp@users.noreply.github.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There was logic in
aws-glue-alpha.Job
that expectedSparkUIProps.prefix
to be specified in the form/prefix-name
, instead of the more conventionalprefix-name/
. This fix addresses the validation and handling of this prefix field to support the correct format.BREAKING CHANGE:
SparkUIProps.prefix
strings in the original/prefix-name
format will now result in a validation error. To retain the same behavior, prefixes must be changed to the newprefix-name/
format.Closes #27396.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license