Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-resources): custom resource provider can't exceed 1 hour #27533

Merged
merged 5 commits into from
Oct 16, 2023
Merged

fix(custom-resources): custom resource provider can't exceed 1 hour #27533

merged 5 commits into from
Oct 16, 2023

Conversation

mikewrighton
Copy link
Contributor

@mikewrighton mikewrighton commented Oct 13, 2023 •
edited
Loading

This change fixes the documentation for ProviderProps.totalTimeout to specify the correct value of 1 hour.

Closes #24974.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 13, 2023 15:15
@github-actions github-actions bot added the p2 label Oct 13, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 13, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed p2 labels Oct 13, 2023
@mikewrighton
Copy link
Contributor Author

Exemption Request: does not modify the CloudFormation output so no snapshot update required.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 13, 2023
@mikewrighton mikewrighton marked this pull request as ready for review October 13, 2023 15:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 13, 2023
@mikewrighton mikewrighton marked this pull request as draft October 13, 2023 20:34
@mikewrighton mikewrighton marked this pull request as ready for review October 16, 2023 19:39
@scanlonp scanlonp added pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Oct 16, 2023
@scanlonp scanlonp added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Oct 16, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 16, 2023 19:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fb934d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b655b08 into main Oct 16, 2023
23 of 27 checks passed
@mergify mergify bot deleted the mikewrighton-24974 branch October 16, 2023 19:57
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib: Custom resource provider can't exceed 1 hour
3 participants
@mikewrighton @aws-cdk-automation @scanlonp