Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

Merged
merged 10 commits into from
Oct 18, 2023
Merged

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
21785e2
docs(secretsmanager): doc when automaticallyAfter for RotationSchedul…
go-to-k Oct 17, 2023
324066e
add validation for if automaticallyAfter > 1000
go-to-k Oct 17, 2023
0f8bbf3
tweak for error message
go-to-k Oct 18, 2023
d0dd6d0
tweak for a doc
go-to-k Oct 18, 2023
51a4a12
tweak for a test
go-to-k Oct 18, 2023
7be4cee
drop without docs
go-to-k Oct 18, 2023
eb2392d
add comments for maximum value
go-to-k Oct 18, 2023
c161bfb
tweak
go-to-k Oct 18, 2023
23e3422
change comments
go-to-k Oct 18, 2023
d28ac34
Merge branch 'main' into docs/secrets-rotaion-schedule
mergify[bot] Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface RotationScheduleOptions {
* Specifies the number of days after the previous rotation before
* Secrets Manager triggers the next automatic rotation.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*
*
* The maximum value is 1000 days.
*

Documentation about accepted values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/aws/aws-cdk/pull/27592/files

* A value of zero will disable automatic rotation - `Duration.days(0)`.
* A value of zero (`Duration.days(0)`) will not create RotationRules.
*
* @default Duration.days(30)
*/
Expand Down