-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigatewayv2): defaultAuthorizer cannot be applied to HttpRoute #27576
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
21785e2
docs(secretsmanager): doc when automaticallyAfter for RotationSchedul…
go-to-k de950c7
fix(apigatewayv2): can't apply defaultAuthorizer to HttpRoute
go-to-k 1efb3d6
add an integ test
go-to-k 1e10a0d
refactor for route.ts
go-to-k 21e4aee
fix miss
go-to-k ebacc8e
change integ tests for circular dependency
go-to-k aa00748
tweak
go-to-k afb9bda
tweak
go-to-k df3155b
tweak
go-to-k 9062e3a
add comments
go-to-k 4fc75f4
apply defaultAuthorizationScopes
go-to-k 5c2208f
change tests
go-to-k 81bcb9c
change comments and an integ
go-to-k 4e76464
change integ snapshots
go-to-k ae2a40c
add properties to IHttpApi
go-to-k 2a76067
change integs
go-to-k 5df276c
changed integ.lambda.ts
go-to-k e3e3f9e
change integ.user-pool
go-to-k afd941c
change integ.lambda.ts
go-to-k 5f248aa
change integ.lambda
go-to-k 4e5942f
change integ.lambda before modification
go-to-k 0a188ee
change integs
go-to-k 9e09c7c
change integ.user-pool
go-to-k 40819a1
change align and docs
go-to-k ee11394
change integ.lambda
go-to-k 7ea3c89
change message
go-to-k 0bb478e
tweak for msgs
go-to-k 375b130
Merge branch 'main' into fix/apgwv2-route-authorizer
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...atewayv2-authorizers-alpha/test/http/integ.lambda.js.snapshot/AuthorizerInteg.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please align this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check.
I also added a JWT authorizer to this doc.
40819a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide documentation that describes the usage with a JWT authorizer?
I was only able to verify the COGNITO_USER_POOLS authorizer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... I tried in the integ.lambda with defaultAuthorizationScopes in httpApiWithDefaultAuthorizer, CFn occurred the following error message.
I'll see if I can find any documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is
If you specify the AuthorizerId property, specify CUSTOM or COGNITO_USER_POOLS for this property.
in the CFn doc.I guess this CFn message represents
CUSTOM
COGNITO_USER_POOLS
as JWT.What should we do in CDK doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found only this article.
https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-jwt-authorizer.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to feel that COGNITO_USER_POOLS is all I need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that
COGNITO_USER_POOLS
is sufficient since it generates aJWT
authorizer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, please review again as I have added only COGNITO_USER_POOLS for the message.