Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): support updateConfig properties for managed node groups #27593

Merged
merged 13 commits into from
Oct 31, 2023

Conversation

kishiel
Copy link
Contributor

@kishiel kishiel commented Oct 18, 2023

This is a duplicate of PR 27320 but on a new branch in my repo.

This change enables nodegroups to configure updateConfig properties which will allow nodegroups to upgrade more than 1 instance at a time. The default value of 1 results in slow deployment times which prevented my service pipelines from quickly delivering fixes to my customers. This change allows each nodegroup to specify a maximum count of instances, or percent, which can be upgraded in parallel.

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 18, 2023 14:39
@github-actions github-actions bot added the p2 label Oct 18, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 18, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a new PR 👍
Extra note: I would change the title to feat(eks): support updateConfig properties for managed node groups

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 19, 2023
@kishiel kishiel changed the title feat(eks): managed nodegroups can specify updateConfig properties feat(eks): support updateConfig properties for managed node groups Oct 19, 2023
@kishiel
Copy link
Contributor Author

kishiel commented Oct 19, 2023

Title changed based on your suggestion.

sumupitchayan
sumupitchayan previously approved these changes Oct 24, 2023
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution!

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kishiel
Copy link
Contributor Author

kishiel commented Oct 30, 2023

For security reasons, Mergify can't update this pull request. Try updating locally.

Looks like this has been sitting for a few days. Is there something I need to do on my end?

@vinayak-kukreja
Copy link
Contributor

Apologies, looks like this did not auto merge. Tracking to merge.

@vinayak-kukreja
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@mergify mergify bot dismissed sumupitchayan’s stale review October 30, 2023 23:34

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 31, 2023
Copy link
Contributor

mergify bot commented Oct 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 31, 2023
Copy link
Contributor

mergify bot commented Oct 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3bf5c5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f9ee5e6 into aws:main Oct 31, 2023
10 checks passed
Copy link
Contributor

mergify bot commented Oct 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants