chore: add sinon dep #27596
chore: add sinon dep #27596
Conversation
Add an explicit dependency on a version of sinon that we depend on in other packages. This version is what is used by `aws-cdk-lib` currently. This fixes an issue that occurs currently when installing @aws-cdk-testing/cli-integ in a directory that is not a git repository as described [in this issue](sinonjs/sinon#2557). This doesn't occur during local development because yarn dedupes sinon to a version that intersects with the peerDep range taken by `ts-mock-imports` and versions depended on by other packages, such as `aws-cdk-lib`.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
MrArnoldPalmer
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add an explicit dependency on a version of sinon that we depend on in other packages. This version is what is used by
aws-cdk-libcurrently. This fixes an issue that occurs currently when installing @aws-cdk-testing/cli-integ in a directory that is not a git repository as described in this issue.This doesn't occur during local development because yarn dedupes sinon to a version that intersects with the peerDep range taken by
ts-mock-importsand versions depended on by other packages, such asaws-cdk-lib. Also it's in a git repo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license