feat(cloudfront): add lambda association #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relates to #1575, but it does not fix the entire issue |
rix0rrr
reviewed
Jun 7, 2019
rix0rrr
reviewed
Jun 7, 2019
This enables to associate a lambda to a distribution behaviour. The lambda could be associated with the four available event-types.
The lambda associations requires a lambda version ARN instead of the function ARN. This in turn requires the exposure of the versionArn from the lambda version template.
KnisterPeter
force-pushed
the
cloudfront-lambda-edge
branch
from
df7da62 to
5fbddce
Compare
|
@rix0rrr Updated this PR and integrated all our requests But there are still parts missing... Right now I could not get my lambda to deploy. I'll investigate and update this when I've managed to fix it. |
KnisterPeter
force-pushed
the
cloudfront-lambda-edge
branch
from
5fbddce to
ed5cb66
Compare
rix0rrr
approved these changes
Jun 12, 2019
ScOut3R
pushed a commit
to ScOut3R/aws-cdk
that referenced
this pull request
Jun 13, 2019
This enables to associate a lambda to a distribution behaviour. The lambda could be associated with the four available event-types.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables to associate a lambda to a distribution behaviour.
The lambda could be associated with the four available event-types.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.