Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prlint): add rule to reject pr contribution from main branch #27617

Merged
merged 5 commits into from
Oct 20, 2023
Merged

chore(prlint): add rule to reject pr contribution from main branch #27617

merged 5 commits into from
Oct 20, 2023

Conversation

vinayak-kukreja
Copy link
Contributor

This PR will add a rule to our prlint to reject PRs opened from an author's main branch on their fork.

@vinayak-kukreja
feat(prlint): add rule to reject pr contribution from main branch
b29d5c2 
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team October 19, 2023 21:29
@github-actions github-actions bot added the p2 label Oct 19, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 19, 2023
@vinayak-kukreja vinayak-kukreja marked this pull request as draft October 19, 2023 21:30
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vinayak-kukreja
close pr on this error
bc082d0 
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@vinayak-kukreja vinayak-kukreja changed the title feat(prlint): add rule to reject pr contribution from main branch chore(prlint): add rule to reject pr contribution from main branch Oct 19, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 19, 2023 21:59

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@vinayak-kukreja vinayak-kukreja marked this pull request as ready for review October 19, 2023 22:04
vinayak-kukreja and others added 3 commits October 19, 2023 15:04
@vinayak-kukreja
Merge branch 'main' into vkukreja/pr-on-main-branch
724af53
@vinayak-kukreja
comment closing pr logic to first test the linter rule
41063ac 
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@vinayak-kukreja
comment update
2500543 
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2500543
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0e81c19 into main Oct 20, 2023
16 checks passed
@mergify mergify bot deleted the vkukreja/pr-on-main-branch branch October 20, 2023 14:23
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 20, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayak-kukreja @aws-cdk-automation @kaizencc