Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec2cdk): support local, temporary service files #27675

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 25, 2023

To work with new features that are not released on CFN yet, we need the ability to provide local schema overrides. This changes adds support for this, by importing additional schema files into the model database before codegen.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 25, 2023 13:30
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 25, 2023
@mrgrain mrgrain force-pushed the mrgrain/chore/support-schema-patches branch from bd2fcf8 to 218af10 Compare October 25, 2023 16:44
To work with new features that are not released on CFN yet, we need the ability to provide local schema overrides.
This changes adds support for this, by importing additional schema files into the model database before codegen.
@mrgrain mrgrain force-pushed the mrgrain/chore/support-schema-patches branch from 218af10 to 291f5d8 Compare October 25, 2023 16:52
@mrgrain mrgrain marked this pull request as ready for review October 25, 2023 16:59
@aws aws deleted a comment from aws-cdk-automation Oct 25, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 291f5d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit afb3e67 into main Oct 25, 2023
15 checks passed
@mergify mergify bot deleted the mrgrain/chore/support-schema-patches branch October 25, 2023 17:21
mrgrain added a commit that referenced this pull request Nov 1, 2023
To work with new features that are not released on CFN yet, we need the ability to provide local schema overrides. This changes adds support for this, by importing additional schema files into the model database before codegen.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants