Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Oct 26, 2023

This PR is to experiment running aws-sdk-js-codemod on aws-cdk by running the following command:

$ npx aws-sdk-js-codemod@0.25.1 -t v2-to-v3 $(grep aws-sdk packages/aws-cdk/lib/**/*.ts | cut -d":" -f1 | uniq | tr '\n' ' ')

It's created just to check if any new bug reports or new feature requests can be added to codemod.

If you're a aws-cdk-owner, feel free to unsubscribe.
If you can provide any comments on how codemod can be improved, it would be helpful!

Previous attempt #26624

@github-actions github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Oct 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 26, 2023 16:43
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 26, 2023
@trivikr trivikr force-pushed the aws-cdk-js-v3-codemod branch from d4a5e3d to 181a7d0 Compare October 26, 2023 16:54
@trivikr trivikr force-pushed the aws-cdk-js-v3-codemod branch from 181a7d0 to 722b581 Compare October 26, 2023 17:07
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'cdk' instead of 'aws-cdk'.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/27697/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@trivikr
Copy link
Member Author

trivikr commented Oct 26, 2023

Closing the PR to avoid messages from bot.
Feel free to comment on it though, or create/upvote issues on codemod.

@trivikr trivikr closed this Oct 26, 2023
@trivikr
Copy link
Member Author

trivikr commented Oct 26, 2023

If there's an update, I'll post another PR with version of codemod used.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 722b581
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@@ -1,3 +1,71 @@
const {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import over Require support was added in v0.25.3 introduced in aws/aws-sdk-js-codemod#652

@trivikr trivikr deleted the aws-cdk-js-v3-codemod branch March 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/needs-cli-test-run This PR needs CLI tests run against it. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants