-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(aws-cdk): use aws-sdk-js-codemod@0.25.1 for moving to JS SDK v3 #27697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
d4a5e3d to
181a7d0
Compare
181a7d0 to
722b581
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
Closing the PR to avoid messages from bot. |
|
If there's an update, I'll post another PR with version of codemod used. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -1,3 +1,71 @@ | |||
| const { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import over Require support was added in v0.25.3 introduced in aws/aws-sdk-js-codemod#652
This PR is to experiment running aws-sdk-js-codemod on aws-cdk by running the following command:
$ npx aws-sdk-js-codemod@0.25.1 -t v2-to-v3 $(grep aws-sdk packages/aws-cdk/lib/**/*.ts | cut -d":" -f1 | uniq | tr '\n' ' ')It's created just to check if any new bug reports or new feature requests can be added to codemod.
If you're a aws-cdk-owner, feel free to unsubscribe.
If you can provide any comments on how codemod can be improved, it would be helpful!
Previous attempt #26624