Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more details to CONTRIBUTING #27703

Merged
merged 6 commits into from
Oct 31, 2023
Merged

chore: add more details to CONTRIBUTING #27703

merged 6 commits into from
Oct 31, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Add more details to our contributing guidelines about what we look for in contributions to aws/aws-cdk and what may be better suited to third party packages. If there are other details and guidelines that we should enumerate up front we should add those here as well.

Added a fancy little diagram cause they are fun and I'm the best.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 26, 2023 21:50
@github-actions github-actions bot added the p2 label Oct 26, 2023
@MrArnoldPalmer MrArnoldPalmer changed the title Chore/contrib docs chore: add more details to CONTRIBUTING Oct 26, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 26, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 26, 2023
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Oct 27, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 27, 2023
@MrArnoldPalmer MrArnoldPalmer removed the pr/do-not-merge This PR should not be merged at this time. label Oct 31, 2023
Copy link
Contributor

mergify bot commented Oct 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8e15e77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1310a26 into main Oct 31, 2023
12 checks passed
@mergify mergify bot deleted the chore/contrib-docs branch October 31, 2023 20:46
Copy link
Contributor

mergify bot commented Oct 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants