Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk): Move version check TTL file to home directory #2774

Merged
merged 5 commits into from
Jun 11, 2019
Merged

fix(aws-cdk): Move version check TTL file to home directory #2774

merged 5 commits into from
Jun 11, 2019

Commits on Jun 6, 2019

  1. fix(aws-cdk): Move version check TTL file to home directory

    Originally, the version check TTL file was located alongside the CDK
    node installation directory. This caused issues for people who had CDK
    installed on a readonly filesystem.
    
    This change moves this file to the user's home directory, specifically
    under $HOMEDIR/.cdk/cache. This directory is already being used by
    account-cache.ts.
    
    The old logic is maintained where a repo check is run once a day against
    NPM, when a CDK command is invoked, and when a new version is present
    will generate a console banner notifying the user of this.
    
    The edge case with the updated implementation is when there are 2+
    active installations of CDK and they are used interchangably. When
    this happens, the user will only get one notification per non-latest
    installation of CDK per day.
    Niranjan Jayakar committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    715ce52 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Feedback from Pull Request

    * Drop use of fs and use fs-extra exclusively.
    * Cleaned up file write.
    * Fixed breaking unit test.
    
    #2774
    Niranjan Jayakar committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    d786634 View commit details
    Browse the repository at this point in the history
  2. Switched error messaging level to debug

    Niranjan Jayakar committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    d419981 View commit details
    Browse the repository at this point in the history
  3. Use async writeFile

    rix0rrr authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    debfb2c View commit details
    Browse the repository at this point in the history
  4. Fix failing tests

    Niranjan Jayakar committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    fb67caa View commit details
    Browse the repository at this point in the history