Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dynamodb): migrate replica handler #27798

Merged
merged 16 commits into from
Nov 29, 2023
Merged

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Nov 1, 2023

This PR moves the dynamodb replica handler from aws-cdk-lib to our new centralized location for custom resource handlers in the @aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2023 16:05
@github-actions github-actions bot added the p2 label Nov 1, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 1, 2023
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Nov 1, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 1, 2023
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Nov 1, 2023
@colifran colifran changed the title chore(dynamodb): migrate replica handler to centralized location for custom resource handlers in @aws-cdk chore(dynamodb): migrate replica handler Nov 6, 2023
@colifran colifran marked this pull request as draft November 7, 2023 17:44
colifran and others added 6 commits November 17, 2023 12:23
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 21, 2023
@colifran colifran marked this pull request as ready for review November 21, 2023 19:33
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Nov 21, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 21, 2023
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran marked this pull request as draft November 28, 2023 22:14
@colifran colifran marked this pull request as ready for review November 28, 2023 22:14
colifran and others added 2 commits November 28, 2023 15:38
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a9bfb29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 20bfa72 into main Nov 29, 2023
13 checks passed
@mergify mergify bot deleted the colifran/migrate-handlers branch November 29, 2023 00:07
chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this pull request Dec 5, 2023
This PR moves the dynamodb replica handler from `aws-cdk-lib` to our new centralized location for custom resource handlers in the `@aws-cdk` package.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. handler-migration p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants