-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dynamodb): migrate replica handler #27798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
aws-cdk-automation
added
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Nov 1, 2023
Signed-off-by: Francis <colifran@amazon.com>
colifran
added
pr/do-not-merge
This PR should not be merged at this time.
and removed
pr/do-not-merge
This PR should not be merged at this time.
labels
Nov 1, 2023
colifran
changed the title
chore(dynamodb): migrate replica handler to centralized location for custom resource handlers in @aws-cdk
chore(dynamodb): migrate replica handler
Nov 6, 2023
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
aws-cdk-automation
removed
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Nov 21, 2023
aws-cdk-automation
added
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Nov 21, 2023
Signed-off-by: Francis <colifran@amazon.com>
vinayak-kukreja
approved these changes
Nov 28, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
chenjane-dev
pushed a commit
to chenjane-dev/aws-cdk
that referenced
this pull request
Dec 5, 2023
This PR moves the dynamodb replica handler from `aws-cdk-lib` to our new centralized location for custom resource handlers in the `@aws-cdk` package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution/core
This is a PR that came from AWS.
handler-migration
p2
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the dynamodb replica handler from
aws-cdk-lib
to our new centralized location for custom resource handlers in the@aws-cdk
package.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license