Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ec2): migrate restrict default security group handler #27807

Merged
merged 13 commits into from
Nov 20, 2023
Merged

chore(ec2): migrate restrict default security group handler #27807

merged 13 commits into from
Nov 20, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Nov 2, 2023

This PR moves the ec2 restrict default security group handler from aws-cdk-lib to our new centralized location for custom resource handlers in the @aws-cdk package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@colifran
migrated restrict default security group handler
60ad437 
Signed-off-by: Francis <colifran@amazon.com>
@colifran
snaps
fe6dbdc 
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2023 04:13
@github-actions github-actions bot added the p2 label Nov 2, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 2, 2023
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Nov 2, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 2, 2023
@colifran colifran changed the title chore(ec2): migrate restrict default security group handler to centralized location for custom resource handlers in @aws-cdk chore(ec2): migrate restrict default security group handler Nov 6, 2023
@github-actions github-actions bot added the p2 label Nov 6, 2023
@colifran colifran marked this pull request as draft November 7, 2023 17:46
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 9, 2023
@colifran colifran marked this pull request as ready for review November 16, 2023 21:05
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 16, 2023
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Nov 17, 2023
vinayak-kukreja
vinayak-kukreja reviewed Nov 20, 2023
View reviewed changes
yarn.lock Outdated
@@ -2023,6 +2023,20 @@
"@smithy/types" "^2.3.3"
tslib "^2.5.0"

"@aws-sdk/middleware-sdk-ec2@3.433.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be 3.421.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran yarn install locally and pushed the changes. This is fixed

@colifran
yarn lock
742c670 
Signed-off-by: Francis <colifran@amazon.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 28a94de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 26e6c50 into main Nov 20, 2023
12 checks passed
@mergify mergify bot deleted the colifran/migrate-restrict-default-security branch November 20, 2023 18:35
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. handler-migration p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colifran @aws-cdk-automation @vinayak-kukreja