feat(cloudformation-diff): use awscdk-service-spec as data source #27813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Nov 2, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
force-pushed
the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
from
3ac396d to
df120c2
Compare
mrgrain
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
force-pushed
the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
2 times, most recently
from
bff13b6 to
a103043
Compare
rix0rrr
reviewed
Nov 3, 2023
mrgrain
force-pushed
the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
3 times, most recently
from
e6d4c09 to
3dc78f7
Compare
mrgrain
force-pushed
the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
2 times, most recently
from
5932514 to
97f9dc8
Compare
mrgrain
force-pushed
the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
from
97f9dc8 to
3bd52d9
Compare
rix0rrr
approved these changes
Nov 6, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
mrgrain/feat/cloudformation-diff-to-use-new-servicespec
branch
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
…e_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" (#28199) After #27813 the `deploy` action was broken with the above error. This is effectively the same as #27983 . To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for `cli-lib` to `@aws-cdk-testing/cli-integtests`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
chenjane-dev
pushed a commit
to chenjane-dev/aws-cdk
that referenced
this pull request
Dec 5, 2023
…e_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" (aws#28199) After aws#27813 the `deploy` action was broken with the above error. This is effectively the same as aws#27983 . To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for `cli-lib` to `@aws-cdk-testing/cli-integtests`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already changed the datasource for generated resource to use
@aws-cdk/awscdk-service-spec.However
cloudformation-diffwas still using the old data source.This PR swaps out the source, with minimal further changes.
Hence no additional tests are required.
Note that this new implementation does not apply
temporary-schemasdefined inspec2cdk.This is because
temporary-schemasis a mechanism to unblock development of unreleased features, and not a mechanism to publish schema changes.For the latter, changes must be made in cdklabs/awscdk-service-spec.
I ran a local benchmark and
cdk diffis now running ~1.03 slower than before.I investigated why and this appears to be mostly due to the gzip compression of the database file.
If we load the DB from an uncompressed source, the new code path performs ~1.07 times faster than the old code path. This trade-off is acceptable.
Compressed package size of
aws-cdkis reducing with this change from11.7MBto8.9MBBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license