feat(scheduler-targets-alpha): `KinesisDataFirehosePutRecord` Target #27842

go-to-k · 2023-11-05T05:25:38Z

This PR adds KinesisDataFirehosePutRecord as a target for an EventBridge scheduler.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Looks good 👍
Just some minor documentation adjustments needed.

lpizzinidev · 2023-11-08T10:47:23Z

packages/@aws-cdk/aws-scheduler-targets-alpha/README.md

+
+## Put records to an Amazon Kinesis Data Firehose
+
+Use the `KinesisDataFirehosePutRecord` target to put records to an Amazon Kinesis Data Firehose.


Suggested change

Use the `KinesisDataFirehosePutRecord` target to put records to an Amazon Kinesis Data Firehose.

Use the `KinesisDataFirehosePutRecord` target to put a record to a Kinesis Data Firehose delivery stream.

lpizzinidev · 2023-11-08T10:49:00Z

packages/@aws-cdk/aws-scheduler-targets-alpha/README.md

+import * as kinesisfirehose from 'aws-cdk-lib/aws-kinesisfirehose';
+
+declare const deliveryStream: kinesisfirehose.CfnDeliveryStream;


Suggested change

import * as kinesisfirehose from 'aws-cdk-lib/aws-kinesisfirehose';

declare const deliveryStream: kinesisfirehose.CfnDeliveryStream;

import * as firehose from 'aws-cdk-lib/aws-kinesisfirehose';

declare const deliveryStream: firehose.CfnDeliveryStream;

lpizzinidev · 2023-11-08T10:49:46Z

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/kinesis-data-firehose-put-record.ts

+
+  protected addTargetActionToRole(schedule: ISchedule, role: IRole): void {
+    if (!sameEnvDimension(this.deliveryStream.stack.region, schedule.env.region)) {
+      throw new Error(`Cannot assign firehose in region ${this.deliveryStream.stack.region} to the schedule ${Names.nodeUniqueId(schedule.node)} in region ${schedule.env.region}. Both the schedule and the firehose must be in the same region.`);


Suggested change

throw new Error(`Cannot assign firehose in region ${this.deliveryStream.stack.region} to the schedule ${Names.nodeUniqueId(schedule.node)} in region ${schedule.env.region}. Both the schedule and the firehose must be in the same region.`);

throw new Error(`Cannot assign the Firehose delivery stream in region ${this.deliveryStream.stack.region} to the schedule ${Names.nodeUniqueId(schedule.node)} in region ${schedule.env.region}. Both the schedule and the Firehose delivery stream must be in the same region.`);

lpizzinidev · 2023-11-08T10:50:03Z

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/kinesis-data-firehose-put-record.ts

+    }
+
+    if (!sameEnvDimension(this.deliveryStream.stack.account, schedule.env.account)) {
+      throw new Error(`Cannot assign firehose in account ${this.deliveryStream.stack.account} to the schedule ${Names.nodeUniqueId(schedule.node)} in account ${schedule.env.region}. Both the schedule and the firehose must be in the same account.`);


Suggested change

throw new Error(`Cannot assign firehose in account ${this.deliveryStream.stack.account} to the schedule ${Names.nodeUniqueId(schedule.node)} in account ${schedule.env.region}. Both the schedule and the firehose must be in the same account.`);

throw new Error(`Cannot assign the Firehose delivery stream in account ${this.deliveryStream.stack.account} to the schedule ${Names.nodeUniqueId(schedule.node)} in account ${schedule.env.region}. Both the schedule and the Firehose delivery stream must be in the same account.`);

go-to-k · 2023-11-08T11:21:09Z

@lpizzinidev

Thanks! Please check the changes.

lpizzinidev

Thanks 👍

aws-cdk-automation · 2023-11-30T00:08:57Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…cheduler-targets-firehose

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja

Hey @go-to-k, thank you for this contribution.

mergify · 2023-11-30T23:37:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

go-to-k · 2023-12-01T03:23:03Z

@vinayak-kukreja

Thanks for your approval! I fixed conflicts. Please approve again.

I fixed the other PR the same way, but when one of them gets merged, the other one gets conflicts again. If that happens, I will fix it again.

vinayak-kukreja · 2023-12-04T17:17:26Z

Hey @go-to-k , thank you for fixing the conflicts. The other PR is now merged. Please let me know once you have fixed conflicts for this PR.

aws-cdk-automation · 2023-12-05T00:09:43Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…cheduler-targets-firehose

go-to-k · 2023-12-05T06:21:05Z

@vinayak-kukreja

Thanks, I fixed new conflicts in this PR again, please look at this.

aws-cdk-automation · 2023-12-05T16:34:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: f8d1f44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-12-05T16:35:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…ws#27842) This PR adds KinesisDataFirehosePutRecord as a target for an EventBridge scheduler. Closes aws#27450. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(scheduler-targets): KinesisDataFirehosePutRecord Target

f2ca64d

aws-cdk-automation requested a review from a team November 5, 2023 05:25

github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 5, 2023

aws-cdk-automation previously requested changes Nov 5, 2023

View reviewed changes

go-to-k added 5 commits November 5, 2023 15:09

change an unit test

f4435eb

change order in an unit test

9547aba

fix unit tests

18c0b01

rm an integ test

26930d4

add an integ test

38cf374

go-to-k marked this pull request as ready for review November 5, 2023 07:51

go-to-k marked this pull request as draft November 5, 2023 09:20

change an integ test

fb5b027

go-to-k marked this pull request as ready for review November 5, 2023 13:18

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 5, 2023

go-to-k added 2 commits November 6, 2023 16:16

improve an unit test

c1214bd

change README and use default value for props

2cb5cd6

lpizzinidev suggested changes Nov 8, 2023

View reviewed changes

change by the review

550ddbe

lpizzinidev approved these changes Nov 8, 2023

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 8, 2023

Merge branch 'main' into feat/scheduler-targets-firehose

c6b1563

go-to-k added 2 commits November 30, 2023 17:04

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into feat/s…

bbb78fd

…cheduler-targets-firehose

Update README.md

9490651

Merge branch 'main' into feat/scheduler-targets-firehose

3c7e08e

vinayak-kukreja self-assigned this Nov 30, 2023

vinayak-kukreja changed the title ~~feat(scheduler-targets): KinesisDataFirehosePutRecord Target~~ feat(scheduler-targets-alpha): KinesisDataFirehosePutRecord Target Nov 30, 2023

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 30, 2023

run integ test

45a3ee9

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja previously approved these changes Nov 30, 2023

View reviewed changes

github-actions bot mentioned this pull request Dec 1, 2023

Monthly PR metrics report - November 2023 #28212

Closed

fix conflicts

13331b7

go-to-k requested a review from vinayak-kukreja December 1, 2023 03:20

go-to-k mentioned this pull request Dec 1, 2023

feat(scheduler-targets-alpha): KinesisStreamPutRecord Target #27845

Merged

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 1, 2023

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into feat/s…

0fba109

…cheduler-targets-firehose

Merge branch 'main' into feat/scheduler-targets-firehose

f8d1f44

vinayak-kukreja approved these changes Dec 5, 2023

View reviewed changes

mergify bot merged commit 46f3a00 into aws:main Dec 5, 2023
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scheduler-targets-alpha): `KinesisDataFirehosePutRecord` Target #27842

feat(scheduler-targets-alpha): `KinesisDataFirehosePutRecord` Target #27842

go-to-k commented Nov 5, 2023

aws-cdk-automation left a comment

lpizzinidev left a comment

lpizzinidev Nov 8, 2023

lpizzinidev Nov 8, 2023

lpizzinidev Nov 8, 2023

lpizzinidev Nov 8, 2023

go-to-k commented Nov 8, 2023

lpizzinidev left a comment

aws-cdk-automation commented Nov 30, 2023

vinayak-kukreja left a comment

mergify bot commented Nov 30, 2023

go-to-k commented Dec 1, 2023

vinayak-kukreja commented Dec 4, 2023

aws-cdk-automation commented Dec 5, 2023

go-to-k commented Dec 5, 2023

aws-cdk-automation commented Dec 5, 2023

mergify bot commented Dec 5, 2023


		## Put records to an Amazon Kinesis Data Firehose

		Use the `KinesisDataFirehosePutRecord` target to put records to an Amazon Kinesis Data Firehose.

		import * as kinesisfirehose from 'aws-cdk-lib/aws-kinesisfirehose';

		declare const deliveryStream: kinesisfirehose.CfnDeliveryStream;

	throw new Error(`Cannot assign firehose in region ${this.deliveryStream.stack.region} to the schedule ${Names.nodeUniqueId(schedule.node)} in region ${schedule.env.region}. Both the schedule and the firehose must be in the same region.`);
	throw new Error(`Cannot assign the Firehose delivery stream in region ${this.deliveryStream.stack.region} to the schedule ${Names.nodeUniqueId(schedule.node)} in region ${schedule.env.region}. Both the schedule and the Firehose delivery stream must be in the same region.`);

feat(scheduler-targets-alpha): KinesisDataFirehosePutRecord Target #27842

feat(scheduler-targets-alpha): KinesisDataFirehosePutRecord Target #27842

Conversation

go-to-k commented Nov 5, 2023

aws-cdk-automation left a comment

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Nov 8, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 8, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 8, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 8, 2023

Choose a reason for hiding this comment

go-to-k commented Nov 8, 2023

lpizzinidev left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Nov 30, 2023

vinayak-kukreja left a comment

Choose a reason for hiding this comment

mergify bot commented Nov 30, 2023

go-to-k commented Dec 1, 2023

vinayak-kukreja commented Dec 4, 2023

aws-cdk-automation commented Dec 5, 2023

go-to-k commented Dec 5, 2023

aws-cdk-automation commented Dec 5, 2023

AWS CodeBuild CI Report

mergify bot commented Dec 5, 2023

feat(scheduler-targets-alpha): `KinesisDataFirehosePutRecord` Target #27842

feat(scheduler-targets-alpha): `KinesisDataFirehosePutRecord` Target #27842