-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cdk): update ADOT Lambda Layer ARNs #27849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
5a9b58d
to
3e399fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you point me to the documentation that corresponds to which regions are enabled for each layer. I see that a number of regions are commented out, but there are more enabled than in the table from your documentation links. For example https://aws-otel.github.io/docs/getting-started/lambda/lambda-python has 16 regions but the table has 22.
08d5cc0
to
96c9d5c
Compare
Pull request has been modified.
The doc you referred is correct - https://aws-otel.github.io/docs/getting-started/lambda/lambda-python. thanks for the good catch. updated the fact-table. it should reflect the appropriate (16 regions) now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the last test in adot.test.ts is failing. Do you get this error locally?
@Mergifyio update |
✅ Branch has been successfully updated |
4de2c48
to
142cd90
Compare
Pull request has been modified.
f57e134
to
676f6dd
Compare
676f6dd
to
70cbed6
Compare
4b27eed
to
54fddd0
Compare
I cannot find where the build is failing. It looks like all the tests are passing. Let us see if retrying solves it. |
I have fixed the unit tests iin adot.test.ts, i guess this will pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Update ADOT Lambda Layer ARNs of latest release. References - - aws-otel/aws-otel.github.io#665 - aws-observability/aws-otel-lambda#763 - aws-observability/aws-otel-lambda#762 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Update ADOT Lambda Layer ARNs of latest release.
References -
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license