Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec2cdk): ICfnResource extends IConstruct #27862

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Nov 6, 2023

We've decided that ICfnResource should extend IConstruct. In addition, I've changed the linter error to correctly reference where IConstruct is coming from. I'll keep it a mystery as to whether I realized beforehand or tried to extend core.IConstruct first.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 6, 2023 21:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2023
@mrgrain mrgrain merged commit 95fe431 into conroy/generate Nov 6, 2023
17 checks passed
@mrgrain mrgrain deleted the cnroy/generate-third branch November 6, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants