Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build by fixing route53 definitions #2788

Merged
merged 1 commit into from
Jun 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-mediastore/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ dist
.LAST_PACKAGE
.jsii

*.tsbuildinfo
*.tsbuildinfo

# Include .jsii
!.jsii
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err... can you remove the .jsii line from L17 then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got added by pkglint. I'm not going to fight it.

5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-pinpointemail/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ dist
.LAST_PACKAGE
.jsii

*.tsbuildinfo
*.tsbuildinfo

# Include .jsii
!.jsii
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err... can you remove the .jsii line from L17 then?

7 changes: 6 additions & 1 deletion packages/@aws-cdk/aws-route53/lib/record-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,12 @@ export class ARecord extends RecordSet {
/**
* Construction properties for a AaaaRecord.
*/
export interface AaaaRecordProps extends RecordSetOptions, ARecordProps {}
export interface AaaaRecordProps extends RecordSetOptions {
/**
* The target.
*/
readonly target: AddressRecordTarget;
}

/**
* A DNS AAAA record
Expand Down
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-transfer/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ dist
.LAST_PACKAGE
.jsii

*.tsbuildinfo
*.tsbuildinfo

# Include .jsii
!.jsii
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err... can you remove the .jsii line from L17 then?