-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rds): add missing rds engine versions #27908
Conversation
Thanks, sounds nice! Just to be sure, could you please post any release notes or reference pages? |
@go-to-k
However, for MySQL v8.0.35 and SQL Server, there is no mention in the documentation, but I can check in the CLI or console. SQL Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for listing docs!
However, for MySQL v8.0.35 and SQL Server, there is no mention in the documentation, but I can check in the CLI or console.
Is it better to exclude these versions that are not documented from this PR?
You can also use the describe-db-engine-versions AWS CLI command to see a list of supported versions, as well as defaults for newly created DB instances.
The SQL Server documentation states that the describe-db-engine-versions
AWS CLI command can be used to check for supported versions. (And you have already done it.)
Also, if they are not beta versions and can be checked successfully in the CLI or console as well as any other versions, I would be good.
Therefore, I approve it in my review.
Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I think the cli check is sufficient to know they are supported.
Thanks!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This Pull Request will add supported RDS engine versions. Added engine versions are as follows. ```sh $ aws rds describe-db-engine-versions \ --query "DBEngineVersions[?EngineVersion=='5.7.44'||EngineVersion=='8.0.35'].[DBEngineVersionDescription,EngineVersion,Status]" \ --engine mysql [ [ "MySQL 5.7.44", "5.7.44", "available" ], [ "MySQL 8.0.35", "8.0.35", "available" ] ] $ aws rds describe-db-engine-versions \ --query "DBEngineVersions[?EngineVersion=='15.00.4322.2.v1'||EngineVersion=='15.00.4335.1.v1'].[DBEngineVersionDescription,EngineVersion,Status]" \ --engine sqlserver-ee [ [ "SQL Server 2019 15.00.4322.2.v1", "15.00.4322.2.v1", "available" ], [ "SQL Server 2019 15.00.4335.1.v1", "15.00.4335.1.v1", "available" ] ] $ aws rds describe-db-engine-versions \ --query "DBEngineVersions[?EngineVersion=='19.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='19.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \ --engine oracle-ee-cdb [ [ "Oracle 19.0.0.0.ru-2023-07.rur-2023-07.r1", "19.0.0.0.ru-2023-07.rur-2023-07.r1", "available" ], [ "Oracle 19.0.0.0.ru-2023-10.rur-2023-10.r1", "19.0.0.0.ru-2023-10.rur-2023-10.r1", "available" ] ] $ aws rds describe-db-engine-versions \ --query "DBEngineVersions[?EngineVersion=='21.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='21.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \ --engine oracle-ee-cdb [ [ "Oracle 21.0.0.0.ru-2023-07.rur-2023-07.r1", "21.0.0.0.ru-2023-07.rur-2023-07.r1", "available" ], [ "Oracle 21.0.0.0.ru-2023-10.rur-2023-10.r1", "21.0.0.0.ru-2023-10.rur-2023-10.r1", "available" ] ] ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This Pull Request will add supported RDS engine versions.
Added engine versions are as follows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license