Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): neuron plugin not added with addNodegroupCapacity() #27909

Merged
merged 5 commits into from
Dec 19, 2023
Merged

fix(eks): neuron plugin not added with addNodegroupCapacity() #27909

merged 5 commits into from
Dec 19, 2023

Commits on Nov 27, 2023

  1. fix(eks): add neuron plugin in addNodegroupCapacity() 

    Previously, the neuron plugin was only added in addAutoScalingGroupCapacity() when
the instanceType was some of the INFERENTIA types.

Let's also add the plugin if at least one (some/any) of the
instanceTypes in addNodegroupCapacity() is of the INFERENTIA types.

added integration tests for the addNodegroupCapacity() feature too,
and snapshot test

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
    @gdamjan @lpizzinidev
    gdamjan and lpizzinidev committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    88f821a View commit details
    Browse the repository at this point in the history

  2. add note about the neuron plugin in the eks README

    @gdamjan
    gdamjan committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    bcbfccf View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'main' into add-neuron-plugin

    @gdamjan
    gdamjan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    32f1e22 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge branch 'main' into add-neuron-plugin

    @paulhcsun
    paulhcsun committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c3b3313 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'main' into add-neuron-plugin

    @mergify
    mergify[bot] committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    0497951 View commit details
    Browse the repository at this point in the history