-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): add AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2 #27910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition, good tests, good docs. The history shows why app version and version are not on the same track for the v2.5.x versions.
The Kubernetes version increase is necessary as versions past 2.5.0 require Kubernetes 1.22+.
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
….2 (#27910) This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2. See the [aws-load-balancer-controller releases](https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases). Each version to correspond to eks-chart versions is based on [aws-load-balancer-controller/Chart.yaml history](https://github.com/aws/eks-charts/commits/master/stable/aws-load-balancer-controller/Chart.yaml). For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts. https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml ```yaml apiVersion: v2 name: aws-load-balancer-controller description: AWS Load Balancer Controller Helm chart for Kubernetes version: 1.6.2 appVersion: v2.6.2 ``` Closes #27890. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2.
See the aws-load-balancer-controller releases.
Each version to correspond to eks-chart versions is based on aws-load-balancer-controller/Chart.yaml history.
For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts.
https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml
Closes #27890.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license