Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert "chore: bump @aws-cdk/asset-awscli-v1 version" #27912

Closed
wants to merge 1 commit into from
Closed

revert "chore: bump @aws-cdk/asset-awscli-v1 version" #27912

wants to merge 1 commit into from

Conversation

vinayak-kukreja
Copy link
Contributor

Reverts #27881

@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2023 16:49
@github-actions github-actions bot added the p2 label Nov 9, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 9, 2023
aws-cdk-automation
aws-cdk-automation requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran changed the title Revert "chore: bump @aws-cdk/asset-awscli-v1 version" revert "chore: bump @aws-cdk/asset-awscli-v1 version" Nov 9, 2023
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e49c37c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vinayak-kukreja
Copy link
Contributor Author

This PR is not necessary since we were able to roll forward with a fix: 0728276

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

@colifran colifran colifran approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayak-kukreja @aws-cdk-automation @colifran