Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lambda-nodejs): fix default runtime docs #27984

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

J11522
Copy link
Contributor

@J11522 J11522 commented Nov 14, 2023

With #26763 the default runtime was reverted from NODEJS_18_X to NODEJS_16_X
This PR reflects this in the docs of the NodejsFunctionProps


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Update docs for default runtime value to  NODEJS_16_X
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2023 13:46
@github-actions github-actions bot added the p2 label Nov 14, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain
Copy link
Contributor

mrgrain commented Nov 14, 2023

@J11522
Copy link
Contributor Author

J11522 commented Nov 15, 2023

This is the logic: https://github.com/aws/aws-cdk/blame/83e37e863ee6cb8ce8c02f6f9c47de5fd2c6bef5/packages/aws-cdk-lib/aws-lambda-nodejs/lib/function.ts#L131-L135

I don't think we can just say Node16 here....

True. I added the explanation to the runtime default

@mrgrain mrgrain changed the title Update default runtime docs docs(lambda-nodejs): fix default runtime docs Nov 15, 2023
mrgrain
mrgrain previously approved these changes Nov 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 15, 2023 11:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Nov 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor

mrgrain commented Nov 15, 2023

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 15, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/update-metadata-regions.yml without workflows permission

@mergify mergify bot dismissed mrgrain’s stale review November 15, 2023 12:56

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 87ccb4c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit db21fef into aws:main Nov 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants