Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): use key instead of logicalId for key when provided #28075

Merged
merged 2 commits into from
Nov 20, 2023
Merged

chore(core): use key instead of logicalId for key when provided #28075

merged 2 commits into from
Nov 20, 2023

Commits on Nov 20, 2023

  1. chore(core): use key instead of logicalId for key when provided 

    In CDK Migrate, when a user has a construct with the same name as their CfnOutput key, it creates a naming collision.

This change enables us to name the construct something else and still use the correct key in creating the output.
Note that the logicalId only makes it into the synthesized template as the output key so this change won't impact existing apps using the CfnOutput construct.
    @TheRealAmazonKendra
    TheRealAmazonKendra committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    4bed9cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into TheRealAmazonKendra/cfn-outputs

    @HBobertz
    HBobertz committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0e2498d View commit details
    Browse the repository at this point in the history