Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cfn-parse does not support this new CFN function -- AccountIdFromAlias #28177

Closed
wants to merge 2 commits into from

Conversation

YYang30
Copy link

@YYang30 YYang30 commented Nov 28, 2023

Reason for this change:

  • AWS CloudFormation team introduced a new intrinsic function -- AccountIdFromAlias which resolves an aws account alias to its account id during stack operation. This is a preferred way for referencing to an AWS account ID in cloud formation templates. So that we can get rid of hardcoding account-IDs in templates and then automate the region build process.
  • However, AccountIdFromAlias has not yet been added to core/lib/cfn-parse module, as a result of which, cfn-include would fail to import a cloud formation template if it contains the usage of this function.

Solution:

  • Added a new class for this function -- AccountIdFromAlias and updated the logic in cfn-parse so that cfn-parse can recognize it as a valid function.

fixes #27642


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 28, 2023 21:28
@github-actions github-actions bot added bug This issue is a bug. p1 labels Nov 28, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@YYang30 YYang30 closed this Nov 28, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3b2725c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib): (Add support for this CfnIntrinsic function -- Fn::AccountIdFromAlias)
2 participants