Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-cdk-lib): fix error message using deprecated 'name' property #28275

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Dec 6, 2023

Instead of throwing the descriptive error, we throw:

ReferenceError: name is not defined

We meant to use submodule.name, not name.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2023 20:03
@kaizencc kaizencc changed the title chore(spec2cdk): fix error message using deprecated 'name' property chore(aws-cdk-lib): fix error message using deprecated 'name' property Dec 6, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 6, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a48abc6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2023
Copy link
Contributor

mergify bot commented Dec 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b5a574f into main Dec 6, 2023
30 checks passed
@mergify mergify bot deleted the kaizencc-patch-8 branch December 6, 2023 21:56
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants