Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include basic changelog in service spec database upgrade PRs #28324

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 11, 2023

Currently it's very difficult to figure out which PR introduced a specific change to the model.

Ideally the changelog would be in a nice narrative form suitable for humans, but in lack of a tool that produces this, the "raw" database diff is better than nothing.

Test-run:
https://github.com/aws/aws-cdk/actions/runs/7168292995
#28326


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 11, 2023 13:28
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 11, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d0a817a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2d17b97 into main Dec 11, 2023
13 checks passed
@mergify mergify bot deleted the mrgrain/chore/spec-changelog branch December 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants