Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk-testing): fix integ test case using unrestricted principal for role #28403

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 18, 2023

This test case is flagged up by automated security tooling. There is no actual risk since this is a test stack that is only short-lived and the permissions for the role only allow consuming messages from a queue that doesn't hold any data.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…pal for role

This test case is flagged up by automated security tooling.
There is no actual risk since this is a test stack that is only short-lived and the permissions for the role only allow consuming messages from a queue that doesn't hold any data.
@aws-cdk-automation aws-cdk-automation requested a review from a team December 18, 2023 10:04
@github-actions github-actions bot added the p2 label Dec 18, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain changed the title chore(aws-cdk-testing): fix integ test case using unrestricted principal for role chore(cdk-testing): fix integ test case using unrestricted principal for role Dec 18, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 18, 2023 10:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7b7306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5b36eed into main Dec 18, 2023
28 of 29 checks passed
@mergify mergify bot deleted the mrgrain/chore/fix-iam-principle-in-test branch December 18, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants