Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(integ-tests): revert add waiterProvider to IApiCall #28457

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore(integ-tests): revert add waiterProvider to IApiCall #28457

merged 1 commit into from
Dec 21, 2023

Conversation

comcalvi
Copy link
Contributor

Reverts #27844. This change broke the pipeline, pacmak fails with:

#STDOUT> /tmp/npm-packu6YRYj/Amazon.CDK.IntegTests.Alpha/Amazon/CDK/IntegTests/Alpha/ApiCallBase.cs(231,77): error CS0115: 'ApiCallBase._Proxy.WaiterProvider': no suitable method found to override [/tmp/npm-packu6YRYj/Amazon.CDK.IntegTests.Alpha/Amazon.CDK.IntegTests.Alpha.csproj]

@github-actions github-actions bot added the p2 label Dec 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 21, 2023 20:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 21, 2023
aws-cdk-automation

This comment was marked as resolved.

Sign in to view

@comcalvi comcalvi changed the title Revert "chore(integ-tests): add waiterProvider to IApiCall" chore(integ-tests): revert add waiterProvider to IApiCall Dec 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 21, 2023 21:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 93cb8e9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 16a1a62 into main Dec 21, 2023
27 of 29 checks passed
@mergify mergify bot deleted the revert-27844-feat/waiterProvider-IApiCall branch December 21, 2023 21:22
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@comcalvi @paulhcsun
chore(integ-tests): revert add waiterProvider to IApiCall (aws#28457)
cbfd427 
Reverts aws#27844. This change broke the pipeline, pacmak fails with:

```
#STDOUT> /tmp/npm-packu6YRYj/Amazon.CDK.IntegTests.Alpha/Amazon/CDK/IntegTests/Alpha/ApiCallBase.cs(231,77): error CS0115: 'ApiCallBase._Proxy.WaiterProvider': no suitable method found to override [/tmp/npm-packu6YRYj/Amazon.CDK.IntegTests.Alpha/Amazon.CDK.IntegTests.Alpha.csproj]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SankyRed SankyRed SankyRed approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comcalvi @aws-cdk-automation @SankyRed