feat(ecs): nvidia support to BottlerocketEcsVariant enum for gpu-accelerated tasks #28488
Conversation
github-actions
bot
added
effort/small
github-actions
bot
added
the
valued-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
badmintoncryer
changed the title
| }); | ||
| cluster.addCapacity('bottlerocket-asg', { | ||
| minCapacity: 2, | ||
| instanceType: new ec2.InstanceType('c5.large'), |
There was a problem hiding this comment.
Don't Nvidia-based images require a GPU-based instance type?
There was a problem hiding this comment.
Certainly! I'll try it later.
There was a problem hiding this comment.
I was asking because from the Console you can deploy only with certain GPU-based instance types and it seemed strange that c5.large would deploy. Not sure if it's possible/worth validating this.
There was a problem hiding this comment.
As you mentioned, this behavior does seem odd. However, since the integration test itself was successful, does this mean that deployment is possible via CloudFormation? Just to be sure, I have switched to integration testing with instances that have GPUs. Please let me know if further verification is needed.
There was a problem hiding this comment.
I guess that CloudFormation correctly deploys the ASG but the instances will fail to launch if the instance type is incompatible with the provided AMI.
We may want to leave it to the user to provide a valid configuration (unless maintainers think otherwise).
aws-cdk-automation
removed
the
pr/needs-community-review
badmintoncryer
force-pushed
the
25980-add1Nvidia
branch
from
cf37b33 to
98a96ad
Compare
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@lpizzinidev Thank you for your review. |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…lerated tasks (aws#28488) This pull request introduces a new variant, AWS_ECS_1_NVIDIA, to the BottlerocketEcsVariant enum. This addition caters to the increasing demand for GPU-accelerated computing in containerized environments, particularly for tasks that require intensive computing power, such as machine learning and 3D rendering. Closes aws#25980 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This pull request introduces a new variant, AWS_ECS_1_NVIDIA, to the BottlerocketEcsVariant enum. This addition caters to the increasing demand for GPU-accelerated computing in containerized environments, particularly for tasks that require intensive computing power, such as machine learning and 3D rendering.
Closes #25980
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license