Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prlint): fix broken link to get trusted members #28505

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

sakurai-ryo
Copy link
Contributor

@sakurai-ryo sakurai-ryo commented Dec 28, 2023

The link to the Wiki page on TrustedMember has changed, and prlint is now failing, so I fixed the broken link in this PR.

スクリーンショット 2023-12-28 14 34 01
https://github.com/aws/aws-cdk/wiki/_compare/17dd5d3103a6cd3350441f20371915d0cd0c1465...4863a52be6383e221667a9c7b9f982f37cac852c

For Example,
https://github.com/aws/aws-cdk/actions/runs/7344487786/job/19996393076?pr=28495
スクリーンショット 2023-12-28 14 37 10


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 28, 2023 05:39
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Dec 28, 2023
@sakurai-ryo sakurai-ryo changed the title chore(prlint): change URL to get TrustedMember chore(prlint): change URL to get trusted members Dec 28, 2023
@sakurai-ryo sakurai-ryo changed the title chore(prlint): change URL to get trusted members chore(prlint): fix broken link to get trusted members Dec 28, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a4fd021
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 28, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sumupitchayan sumupitchayan merged commit cae756c into aws:main Dec 28, 2023
35 checks passed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
The link to the Wiki page on `TrustedMember` has changed, and prlint is
now failing, so I fixed the broken link in this PR.

![スクリーンショット 2023-12-28 14 34
01](https://github.com/aws/aws-cdk/assets/58683719/f776ce9c-fc42-419f-b13e-798c36789125)

https://github.com/aws/aws-cdk/wiki/_compare/17dd5d3103a6cd3350441f20371915d0cd0c1465...4863a52be6383e221667a9c7b9f982f37cac852c

For Example,

https://github.com/aws/aws-cdk/actions/runs/7344487786/job/19996393076?pr=28495
![スクリーンショット 2023-12-28 14 37
10](https://github.com/aws/aws-cdk/assets/58683719/bb3a39a5-7c68-406f-ac9a-0e6e9998961e)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants