fix(appsync): use logretention to always create a log group #28527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if the log group property of GraphQLApi is referred a log group is created beforehand
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Dec 29, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrlikl
changed the title
mrlikl
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates log group for the graphql api even when logging is not enabled and refers the LogRetention custom resource for the property logGroup of
GraphqlApi.using
new LogGroup()can sometimes fail if the log group with same name exists however the custom resource LogRetention will create if not exists.This in turn will avoid the race condition when a subsequent resource that refers GraphqlApi.logGroup is being created in the same stack.
Because the logGroup is now referring to the custom resource's output log ARN and further resources will depend on the custom resource to be created first.
Appsync will not fail if a log group is already present with the api id. It will continue to send logs in it.
Closes #26564
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license