fix(appsync): add dependency to logretention for graphql apis log group #28548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
bug
aws-cdk-automation
added
the
pr/needs-community-review
paulhcsun
reviewed
Jan 18, 2024
packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.appsync-logmetrics.ts
Outdated
Show resolved
Hide resolved
paulhcsun
approved these changes
Jan 18, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a dependency to log retention if logconfig is set for
GraphqlApi. This in turn avoids the race condition when subsequent resources refer to the log group property ofGraphqlApi.logGrouplogGroup is now referring to the custom resource's output log ARN and further resources will depend on the custom resource to be created first.
Closes #26564
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license