Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cdk): Update fact tables and tests for lambda layers v0.90.1 #28567

Merged
merged 11 commits into from
Jan 15, 2024
Merged

chore(cdk): Update fact tables and tests for lambda layers v0.90.1 #28567

merged 11 commits into from
Jan 15, 2024

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Jan 3, 2024 •
edited
Loading

Add ADOT Lambda Layer ARNs for recent release

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 3, 2024 21:48
@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK p2 labels Jan 3, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vasireddy99 vasireddy99 changed the title Update fact tables and tests for lambda layers v0.90.1 chore(cdk):Update fact tables and tests for lambda layers v0.90.1 Jan 4, 2024
@vasireddy99 vasireddy99 marked this pull request as ready for review January 4, 2024 14:44
@vasireddy99 vasireddy99 changed the title chore(cdk):Update fact tables and tests for lambda layers v0.90.1 chore(cdk): Update fact tables and tests for lambda layers v0.90.1 Jan 4, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 4, 2024 14:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 4, 2024
lpizzinidev
lpizzinidev suggested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
I left some notes for minor adjustments on tests.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.lambda-adot.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-lambda/lib/adot-layers.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-lambda/test/adot.test.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 4, 2024
lpizzinidev
lpizzinidev approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the clarification 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 5, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 40d7421
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

paulhcsun
paulhcsun approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @vasireddy99, and thank you for reviewing @lpizzinidev!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 06acf4f into aws:main Jan 15, 2024
11 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2024
@vasireddy99 vasireddy99 deleted the lambda90 branch January 16, 2024 05:36
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees
No one assigned
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasireddy99 @aws-cdk-automation @lpizzinidev @paulhcsun