Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codepipeline-actions): bump up the solutionStack in the integ test #28799

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

sakurai-ryo
Copy link
Contributor

@sakurai-ryo sakurai-ryo commented Jan 21, 2024

Currently, the solutionStack of Elastic Beanstalk that is specified is out of date, causing integ tests to fail.

"No Solution Stack named '64bit Amazon Linux 2023 v6.0.2 running Node.js 18' found. (Service: ElasticBeanstalk, Status Code: 400, Request ID: 625a591c-9bb2-4c7c-9404-cf192fdae9bb)"

It may be better in the future that integ-test can always deploy using the latest version using the custom resource.
(It may be difficult to use AwsCustomResource because the size of the SolutionStacks (array) property alone is 4KB.)
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-elastic-beanstalk/Interface/ListAvailableSolutionStacksResultMessage/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2 labels Jan 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2024 14:37
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 21, 2024
kaizencc
kaizencc previously approved these changes Jan 22, 2024
Copy link
Contributor

mergify bot commented Jan 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 22, 2024
Copy link
Contributor

mergify bot commented Jan 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@mergify mergify bot dismissed kaizencc’s stale review January 25, 2024 02:26

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 25, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0eb139a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 1, 2024
@mergify mergify bot merged commit 75ebf9b into aws:main Feb 1, 2024
13 checks passed
Copy link
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

SankyRed pushed a commit that referenced this pull request Feb 8, 2024
…est (#28799)

Currently, the solutionStack of Elastic Beanstalk that is specified is out of date, causing integ tests to fail.
```
"No Solution Stack named '64bit Amazon Linux 2023 v6.0.2 running Node.js 18' found. (Service: ElasticBeanstalk, Status Code: 400, Request ID: 625a591c-9bb2-4c7c-9404-cf192fdae9bb)"
```

It may be better in the future that integ-test can always deploy using the latest version using the custom resource.
(It may be difficult to use AwsCustomResource because the size of the `SolutionStacks` (array) property alone is 4KB.)
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-elastic-beanstalk/Interface/ListAvailableSolutionStacksResultMessage/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
…est (#28799)

Currently, the solutionStack of Elastic Beanstalk that is specified is out of date, causing integ tests to fail.
```
"No Solution Stack named '64bit Amazon Linux 2023 v6.0.2 running Node.js 18' found. (Service: ElasticBeanstalk, Status Code: 400, Request ID: 625a591c-9bb2-4c7c-9404-cf192fdae9bb)"
```

It may be better in the future that integ-test can always deploy using the latest version using the custom resource.
(It may be difficult to use AwsCustomResource because the size of the `SolutionStacks` (array) property alone is 4KB.)
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-elastic-beanstalk/Interface/ListAvailableSolutionStacksResultMessage/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants