-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): a number of resources are not taggable with Tags.of()
#28989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
What we usually do is phrase the PR title as user-visible changes (because the PR titles make it into the CHANGELOG). Since this fixes a bug, I would do something like:
|
Tags.of()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@mergify update |
✅ Branch has been successfully updated |
ecd865a
to
5ff4515
Compare
Any update on this? I am looking forward to a new release ;-) |
@gossandr Will try to get this merged this week. |
@GavinZZ if you need any assistance, i might be able to help |
773e3f4
to
e805aea
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #28862
Reason for this change
CFN resources that has array format
tags
cannot useTags.of()
to add tags.Description of changes
Enable modern style tags
ITaggableV2
Description of how you validated changes
The generated looks correct and shouldn't cause breaking changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license