Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appconfig): deprecate deploy method #29021

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(appconfig): deprecate deploy method #29021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c306f63
fix(appconfig): deprecate deploy method
chenjane-dev Feb 7, 2024
2b60f66
Merge branch 'main' into env-deploy-method
mergify[bot] Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-appconfig-alpha/lib/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,9 @@ abstract class ConfigurationBase extends Construct implements IConfiguration, IE
* Deploys the configuration to the specified environment.
*
* @param environment The environment to deploy the configuration to
* @deprecated Use `deployTo` as a property instead. We do not recommend
* creating resources in multiple stacks. If you want to do this still,
* please take a look into https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_appconfig.CfnDeployment.html.
*/
public deploy(environment: IEnvironment) {
const logicalId = `Deployment${this.getDeploymentHash(environment)}`;
Expand Down